flowchartsman opened a new pull request #12316:
URL: https://github.com/apache/pulsar/pull/12316
- This call will be made by gi.processResult if
- there is a result
- there were no system exceptions
- Fixes #12314
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
**NOTES**
- due to the way the pulsar-function-go SDK is structured, adding regression
tests to the Go code itself would be impossible without spinning up a complete
environment; the call has been removed from the core loop of `startFunction()`,
which depends on a complete environment with successfully-initialized client,
producer, consumer, log producer and metrics server, as well as instance
communication.
- This means that the best way to test this would be in the Java example
tests or E2E testing, but I have been unable to locate any Java tests that
exercise the metrics, so if there is a place I could add this easily, I would
be most grateful (and even more so for a patch or PR :D )
This change added tests and can be verified as follows:
- for the reasons mentioned above, this test must be verified in situ for now
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
-
### Documentation
Check the box below and label this PR (if you have committer privilege).
- [x] no-need-doc
As far as I can tell, this change restores the ProcessedSuccessfully
metric to what it should be:
- <= ReceivedTotal
- Only incremented on a error-free function handler that produces a result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
