flowchartsman commented on pull request #12316: URL: https://github.com/apache/pulsar/pull/12316#issuecomment-939595258
Correct, but that is in the case where the function has no output topic, and is already like that. So, should it be replaced? What is the behavior of the other frameworks? On Sun, Oct 10, 2021 at 9:04 PM Rui Fu ***@***.***> wrote: > ***@***.**** commented on this pull request. > > Seems with this change, it will no longer having metrics recorded with > this case: > https://github.com/apache/pulsar/blame/master/pulsar-function-go/pf/instance.go#L376-L381 > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/pulsar/pull/12316#pullrequestreview-775739289>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAHCJJF6TTKLVF3E3VPT55TUGIZY3ANCNFSM5FWZ7ZMA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
