eolivelli commented on a change in pull request #12343:
URL: https://github.com/apache/pulsar/pull/12343#discussion_r728733851
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java
##########
@@ -466,11 +466,17 @@ public void flush() {
this.lock.writeLock().lock();
try {
flushAsync(cnx);
+ } catch (Exception e) {
Review comment:
An async method should not throw exception
Also catching Exception this way usually is something that we should not do
I suggest to revert the changes in the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
