BewareMyPower commented on a change in pull request #12343:
URL: https://github.com/apache/pulsar/pull/12343#discussion_r728738696
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java
##########
@@ -466,11 +466,17 @@ public void flush() {
this.lock.writeLock().lock();
try {
flushAsync(cnx);
+ } catch (Exception e) {
Review comment:
I think the name `flushAsync` is wrong. It's a confused name. It's
caused by a careless reviews for https://github.com/apache/pulsar/pull/8996.
IMO, the `flushAsync` method is more like an `internalFlush` method. It doesn't
return a `CompletableFuture` and `flush` is not a synchronous version of
`flushAsync`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
