liangyepianzhou commented on a change in pull request #12449:
URL: https://github.com/apache/pulsar/pull/12449#discussion_r734187061
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2289,6 +2302,12 @@ private void
maybeOffload(CompletableFuture<PositionImpl> finalPromise) {
if (alreadyOffloaded) {
alreadyOffloadedSize += size;
} else if (sizeSummed > threshold) {
+ //If the state of TB is noSnapshot, this ledger will
not contain transaction messages
+ if(config.isTransactionEnable()
Review comment:
The state of TransactionBuffer is unnecessary, because we will update
the maxReadPosition when only common messages were sent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
