liangyepianzhou commented on a change in pull request #12449:
URL: https://github.com/apache/pulsar/pull/12449#discussion_r734199708
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2249,6 +2256,12 @@ private void
maybeOffloadInBackground(CompletableFuture<PositionImpl> promise) {
&& config.getLedgerOffloader().getOffloadPolicies() != null
&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
!= null
&&
config.getLedgerOffloader().getOffloadPolicies().getManagedLedgerOffloadThresholdInBytes()
>= 0) {
+ //This means that the topic has not been created yet or the TB has
not been started completely.
+ if(config.isTransactionEnable()){
Review comment:
I think you are right. Even if transaction is not turned on, these
judgments can be performed normally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
