lhotari commented on pull request #12456: URL: https://github.com/apache/pulsar/pull/12456#issuecomment-949485195
> There is a test failure related to this change > > ``` > > org.apache.pulsar.client.impl.MultiTopicsConsumerImplTest.testReceiveAsyncCanBeCancelled(org.apache.pulsar.client.impl.MultiTopicsConsumerImplTest) > [INFO] Run 1: PASS > Error: Run 2: MultiTopicsConsumerImplTest.testReceiveAsyncCanBeCancelled:168 expected [true] but found [false] > ``` @michaeljmarshall the test should be fixed. This line https://github.com/apache/pulsar/blob/bd942e1730780f89b78799ca768fc68277f7965b/pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java#L168 should be wrapped with Awaitility ```java Awaitility.await().untilAsserted(() -> assertTrue(consumer.hasNextPendingReceive())); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
