lhotari commented on a change in pull request #12456:
URL: https://github.com/apache/pulsar/pull/12456#discussion_r734410442
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
##########
@@ -245,7 +245,7 @@ private void startReceivingMessages(List<ConsumerImpl<T>>
newConsumers) {
}
private void receiveMessageFromConsumer(ConsumerImpl<T> consumer) {
Review comment:
The `thenAccept` -> `thenAcceptAsync` change in
`receiveMessageFromConsumer` method should be reverted. This method is executed
in the context of the `internalPinnedExecutor` and the change to use
`thenAcceptAsync` isn't useful because of that. It leads to an additional
unnecessary scheduling step. Not a big deal, but it's unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
