cckellogg commented on a change in pull request #651:
URL: https://github.com/apache/pulsar-client-go/pull/651#discussion_r740362853
##########
File path: pulsar/producer_partition.go
##########
@@ -784,57 +784,57 @@ func (p *partitionProducer) ReceivedSendReceipt(response
*pb.CommandSendReceipt)
return
}
- if pi.sequenceID != response.GetSequenceId() {
+ if pi.sequenceID < response.GetSequenceId() {
Review comment:
So are you suggesting we follow the logic of the java client and handle
the 3 cases this way?
1 - pi.sequenceID > response.GetSequenceId() => return (could there ever be
a pending item in the queue that gets left around?)
2 - pi.sequenceID < response.GetSequenceId() => error close connection
3 - pi.sequenceID == response.GetSequenceId() => process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
