cckellogg commented on a change in pull request #651:
URL: https://github.com/apache/pulsar-client-go/pull/651#discussion_r742266590



##########
File path: pulsar/producer_partition.go
##########
@@ -784,57 +784,57 @@ func (p *partitionProducer) ReceivedSendReceipt(response 
*pb.CommandSendReceipt)
                return
        }
 
-       if pi.sequenceID != response.GetSequenceId() {
+       if pi.sequenceID < response.GetSequenceId() {

Review comment:
       Can we add a log for the last condition `pi.sequenceID > 
response.GetSequenceId()` just to track if we ever see it?
   
   Also, if this condition ever happens do we leak pending items?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to