eolivelli commented on a change in pull request #12654:
URL: https://github.com/apache/pulsar/pull/12654#discussion_r744232276
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
##########
@@ -474,7 +475,13 @@ public void registerListener(TopicName topicName,
TopicPolicyListener<TopicPolic
@Override
public void unregisterListener(TopicName topicName,
TopicPolicyListener<TopicPolicies> listener) {
- listeners.computeIfAbsent(topicName, k ->
Lists.newCopyOnWriteArrayList()).remove(listener);
Review comment:
This change is not threadsafe.
You have to move your code inside the function passed to computeIfAbsent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
