eolivelli commented on a change in pull request #12654:
URL: https://github.com/apache/pulsar/pull/12654#discussion_r746624966
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
##########
@@ -474,7 +475,13 @@ public void registerListener(TopicName topicName,
TopicPolicyListener<TopicPolic
@Override
public void unregisterListener(TopicName topicName,
TopicPolicyListener<TopicPolicies> listener) {
- listeners.computeIfAbsent(topicName, k ->
Lists.newCopyOnWriteArrayList()).remove(listener);
+ List<TopicPolicyListener<TopicPolicies>> topicListeners =
listeners.get(topicName);
+ if (topicListeners != null && topicListeners.remove(listener)) {
+ //delete topic from listeners if it's empty.
+ if (topicListeners.isEmpty()) {
Review comment:
Now I understand that this code will work, but I find it quite
convoluted.
so actually you can remove this "if" condition
Personally I would go with the `computeIfAbsent` way, but probably it is
only a matter of taste.
A unit test around this class is really needed here :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
