RobertIndie commented on a change in pull request #12403:
URL: https://github.com/apache/pulsar/pull/12403#discussion_r745484696
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -61,6 +61,9 @@ message MessageIdData {
optional int32 batch_index = 4 [default = -1];
repeated int64 ack_set = 5;
optional int32 batch_size = 6;
+
+ // For the chunk message id, we need to specify the first chunk message id.
+ optional MessageIdData first_chunk_message_id = 7;
Review comment:
Since ChunkMessageID serialization and deserialization depend on the
`MessageIdData` defined by the proto, we need to change it here even if it does
not need to be passed to the server-side.
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -461,10 +462,11 @@ public void sendAsync(Message<?> message, SendCallback
callback) {
sequenceId = msgMetadata.getSequenceId();
}
String uuid = totalChunks > 1 ? String.format("%s-%d",
producerName, sequenceId) : null;
+ ChunkedMessageCtx chunkedMessageCtx =
ChunkedMessageCtx.RECYCLER.get();
Review comment:
Thanks. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
