rdhabalia commented on a change in pull request #12403:
URL: https://github.com/apache/pulsar/pull/12403#discussion_r746967302
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -61,6 +61,9 @@ message MessageIdData {
optional int32 batch_index = 4 [default = -1];
repeated int64 ack_set = 5;
optional int32 batch_size = 6;
+
+ // For the chunk message id, we need to specify the first chunk message id.
+ optional MessageIdData first_chunk_message_id = 7;
Review comment:
> each chunk is sent in order, so I don't think there is a case where
the last chunk will be acked before the first chunk.
The issue is not ordering of ack but the timing of ack. if you don't receive
ack of first-chunk while publishing other chunks then you can't update
`first_chunk_message_id` in rest of the chunks. if chunks won't have
`first_chunk_message_id` then when the consumer receives chunked-message, those
chunks won't have `firstChunkMessageId` in the metadata and consumer won't be
able to seek to first messageId. which will defeat purpose of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
