rdhabalia commented on a change in pull request #12403:
URL: https://github.com/apache/pulsar/pull/12403#discussion_r758665980
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1975,6 +1982,9 @@ public void seek(Function<String, Object> function)
throws PulsarClientException
ackSet.recycle();
seek = Commands.newSeek(consumerId, requestId,
msgId.getLedgerId(), msgId.getEntryId(), ackSetArr);
+ } else if(messageId instanceof ChunkMessageIdImpl){
+ ChunkMessageIdImpl msgId = (ChunkMessageIdImpl) messageId;
+ seek = Commands.newSeek(consumerId, requestId,
msgId.getFirstChunkMessageId().getLedgerId(),
msgId.getFirstChunkMessageId().getEntryId(), new long[0]);
Review comment:
the fundamental assumption at the consumer side is :
`msgId.getFirstChunkMessageId().getLedgerId()` will be present. and this
assumption is incorrect. `msg -> getFirstChunkMessageId()` can be null because
what I explained earlier: `you can't give guarantee to set firstChunkMessageId
in any chunk of the message.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
