Jason918 commented on a change in pull request #12654:
URL: https://github.com/apache/pulsar/pull/12654#discussion_r747527249
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
##########
@@ -474,7 +475,13 @@ public void registerListener(TopicName topicName,
TopicPolicyListener<TopicPolic
@Override
public void unregisterListener(TopicName topicName,
TopicPolicyListener<TopicPolicies> listener) {
- listeners.computeIfAbsent(topicName, k ->
Lists.newCopyOnWriteArrayList()).remove(listener);
+ List<TopicPolicyListener<TopicPolicies>> topicListeners =
listeners.get(topicName);
+ if (topicListeners != null && topicListeners.remove(listener)) {
+ //delete topic from listeners if it's empty.
+ if (topicListeners.isEmpty()) {
Review comment:
> for computeIfAbsent... if you return "null" it should simply not add
anything to the map
Thx! Great to know. Got a little mixed with
`org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap`, in which a
key with null value will be inserted if return "null" in computeIfAbsent.
See #12729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
