Jason918 commented on a change in pull request #12818:
URL: https://github.com/apache/pulsar/pull/12818#discussion_r749872569
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java
##########
@@ -77,6 +77,7 @@
private int newEntriesCheckDelayInMillis = 10;
private Clock clock = Clock.systemUTC();
private ManagedLedgerInterceptor managedLedgerInterceptor;
+ private Map<String, String> topicMetadata;
Review comment:
In my understanding, this `topicMetadata ` is for meta info of
PartitionedTopic. Does it have anything to do with ManagedLedger？
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
##########
@@ -383,10 +385,28 @@ void run() throws PulsarAdminException {
"--partitions" }, description = "Number of partitions for the
topic", required = true)
private int numPartitions;
+ @Parameter(names = {"--topic-metadata", "-tm"}, description = "key
value pair properties(a=a,b=b,c=c)",
+ required = true)
Review comment:
required = true? IMHO, this should be optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
