yuruguo commented on a change in pull request #12818:
URL: https://github.com/apache/pulsar/pull/12818#discussion_r749886972
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##########
@@ -368,9 +368,10 @@ public void revokePermissions(String topic, String role)
throws PulsarAdminExcep
}
@Override
- public void createPartitionedTopic(String topic, int numPartitions) throws
PulsarAdminException {
+ public void createPartitionedTopic(String topic, int numPartitions,
Map<String, String> metadata)
+ throws PulsarAdminException {
try {
- createPartitionedTopicAsync(topic,
numPartitions).get(this.readTimeoutMs, TimeUnit.MILLISECONDS);
+ createPartitionedTopicAsync(topic, numPartitions,
metadata).get(this.readTimeoutMs, TimeUnit.MILLISECONDS);
Review comment:
suggest to use new method to pack this piece
https://github.com/apache/pulsar/blob/9994614173205abd075fcc670396cebd71227047/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/BaseResource.java#L290
such as
https://github.com/apache/pulsar/blob/9994614173205abd075fcc670396cebd71227047/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/NamespacesImpl.java#L244-L246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
