Anonymitaet commented on a change in pull request #12902:
URL: https://github.com/apache/pulsar/pull/12902#discussion_r754793314
##########
File path: conf/broker.conf
##########
@@ -1097,6 +1097,18 @@
loadBalancerLoadSheddingStrategy=org.apache.pulsar.broker.loadbalance.impl.Overl
# It only takes effect in the ThresholdShedder strategy.
loadBalancerBrokerThresholdShedderPercentage=10
+# Message-rate percentage threshold between highest and least loaded brokers
for
+# uniform load shedding. (eg: broker1 with 50K msgRate and broker2 with 30K
msgRate
+# will have 66% msgRate difference and load balancer can unload bundles from
broker-1
+# to broker-2)
+loadBalancerMsgRateDifferenceShedderThreshold=50
Review comment:
+1
@rdhabalia
For the doc side, how about adding docs like below? (feel free to correct me
if my understanding is wrong)
That is:
- Add a section `Shed load manually`
- 3 strategies (`ThresholdShedder`, `OverloadShedder`, and
`UniformLoadShedder`) belong to `Shed load manually` section
- Add explanations of "when to use" and "how to use" for each strategy
If so, can you add them? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
