rdhabalia commented on a change in pull request #12902:
URL: https://github.com/apache/pulsar/pull/12902#discussion_r756400837
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1773,6 +1773,25 @@
)
private int loadBalancerBrokerThresholdShedderPercentage = 10;
+ @FieldContext(
+ dynamic = true,
+ category = CATEGORY_LOAD_BALANCER,
+ doc = "Message-rate percentage threshold between highest and least
loaded brokers for "
+ + "uniform load shedding. (eg: broker1 with 50K msgRate and
broker2 with 30K msgRate "
+ + "will have 66% msgRate difference and load balancer can
unload bundles from broker-1 "
+ + "to broker-2)"
+ )
+ private int loadBalancerMsgRateDifferenceShedderThreshold = 50;
+ @FieldContext(
+ dynamic = true,
+ category = CATEGORY_LOAD_BALANCER,
+ doc = "Message-throughput threshold between highest and least loaded
brokers for "
+ + "uniform load shedding. (eg: broker1 with 450MB msgRate and
broker2 with 100MB msgRate "
+ + "will have 4.5 times msgThroughout difference and load
balancer can unload bundles "
+ + "from broker-1 to broker-2)"
+ )
+ private int loadBalancerMsgThroughputMultiplierDifferenceShedderThreshold
= 4;
Review comment:
yes, value is double and it supports fractions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
