shibd commented on a change in pull request #13184:
URL: https://github.com/apache/pulsar/pull/13184#discussion_r769215684
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/NamespacesImpl.java
##########
@@ -146,6 +147,56 @@ public void failed(Throwable throwable) {
return future;
}
+ @Override
+ public List<BundleStats> getAllBundleStats(String namespace) throws
PulsarAdminException {
+ return sync(() -> getAllBundleStatsAsync(namespace));
+ }
+
+ @Override
+ public CompletableFuture<List<BundleStats>> getAllBundleStatsAsync(String
namespace) {
+ NamespaceName ns = NamespaceName.get(namespace);
+ WebTarget path = namespacePath(ns, "bundleStats");
+ final CompletableFuture<List<BundleStats>> future = new
CompletableFuture<>();
+ asyncGetRequest(path,
Review comment:
> Ok, Is the interface name ambiguity?
Now, The meaning of the interface maybe misunderstood: `Get the status of
all bundles under the namespace`
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/NamespacesImpl.java
##########
@@ -146,6 +147,56 @@ public void failed(Throwable throwable) {
return future;
}
+ @Override
+ public List<BundleStats> getAllBundleStats(String namespace) throws
PulsarAdminException {
+ return sync(() -> getAllBundleStatsAsync(namespace));
+ }
+
+ @Override
+ public CompletableFuture<List<BundleStats>> getAllBundleStatsAsync(String
namespace) {
+ NamespaceName ns = NamespaceName.get(namespace);
+ WebTarget path = namespacePath(ns, "bundleStats");
+ final CompletableFuture<List<BundleStats>> future = new
CompletableFuture<>();
+ asyncGetRequest(path,
Review comment:
> Ok, Is the interface name ambiguity?
Now, The meaning of the interface maybe misunderstood: `Get the status of
all bundles under the namespace`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
