michaeljmarshall commented on a change in pull request #13184:
URL: https://github.com/apache/pulsar/pull/13184#discussion_r769857505



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -1305,6 +1308,41 @@ protected DispatchRate 
internalGetSubscriptionDispatchRate() {
         return 
policies.subscriptionDispatchRate.get(pulsar().getConfiguration().getClusterName());
     }
 
+    public List<BundleStats> internalGetAllBundleStats() {

Review comment:
       Since it is only returning the stats for the namespace's bundles on this 
broker, I wonder if we should change the name to align with the returned value. 
When I first read the name of this endpoint, I assumed that it'd get the bundle 
stats for all bundles in the namespace. Do you know if we have a precedent for 
this kind of endpoint in the API already?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to