lhotari commented on pull request #13747: URL: https://github.com/apache/pulsar/pull/13747#issuecomment-1014317986
> @lhotari I removed forceJavacCompilerUse and everything builds/pushed the change. Please help me understand what's the downside of just keeping it there/adding in another PR? I presume everyone who updates dependencies now and then gets into that NPE in maven, and have to add the forceJavacCompilerUse to see the errors, and remove it later. So does it hurt build times or anything else? Why don't we make developers' life easier and keep it until we move to the maven/jvm plugin with the [NPE fixed](https://bugs.openjdk.java.net/browse/JDK-8216202) (not soon, probably, as it is not fixed yet)? I believe that the downside is reduced performance. In addition, the problem might happen in any module and therefore it doesn't make sense to change the setting for just a few modules if it were to be enabled globally. There might also be some changes in how maven compiler issues are displayed when forceJavacCompilerUse is used. The way to make developers' life easier is to raise awareness of this issue. I added a simpler workaround to #13126, it's by passing `-Dmaven.compiler.forceJavacCompilerUse=true` to the mvn command line. To make it easier to find this information we could add the information to README or the contributor guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
