lhotari commented on a change in pull request #13716:
URL: https://github.com/apache/pulsar/pull/13716#discussion_r788333123
##########
File path: pom.xml
##########
@@ -576,26 +576,10 @@ flexible messaging model and an intuitive client
API.</description>
<dependency>
<groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-servlet</artifactId>
- <version>${jetty.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-servlets</artifactId>
- <version>${jetty.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-proxy</artifactId>
- <version>${jetty.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-util</artifactId>
+ <artifactId>jetty-bom</artifactId>
Review comment:
Nice change! Please create a separate PR for the jetty-bom change and
the jetty.version upgrade. This change isn't related to Guava and would be
valuable on it's own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
