eolivelli commented on a change in pull request #13716:
URL: https://github.com/apache/pulsar/pull/13716#discussion_r788756334
##########
File path: pom.xml
##########
@@ -576,26 +576,10 @@ flexible messaging model and an intuitive client
API.</description>
<dependency>
<groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-servlet</artifactId>
- <version>${jetty.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-servlets</artifactId>
- <version>${jetty.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-proxy</artifactId>
- <version>${jetty.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-util</artifactId>
+ <artifactId>jetty-bom</artifactId>
Review comment:
IIUC importing the BOM of Jetty solves some problems with the version
of Guava imported by Jetty.
While I agree with @lhotari's concern about tracking broken patches and
reverting, I also understand @dlg99's pain.
Considering that this patch is only about updating dependencies that are
related one to each other I am +1 with merging this patch as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
