lhotari commented on a change in pull request #13839:
URL: https://github.com/apache/pulsar/pull/13839#discussion_r788340956
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -245,6 +245,13 @@
)
private int numIOThreads = 2 * Runtime.getRuntime().availableProcessors();
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "Number of shared threads to use for broker clients."
+ + " Default is set to `2 *
Runtime.getRuntime().availableProcessors()`"
+ )
+ private int brokerClientNumIOThreads = 2 *
Runtime.getRuntime().availableProcessors();
Review comment:
> Yes, I think the confusion comes from the name
brokerClientNumIOThreads, since it's client internal executor and not the
client event loop which is already shared.
That's true. The Pulsar Client uses the `numIOThreads` parameter for
configuring the number of threads for the `eventLoopGroup` and also for the
internal/IO executor.
https://github.com/apache/pulsar/blob/4591a210a8d924d99811edfdfeb7433452e5eeb4/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java#L979
https://github.com/apache/pulsar/blob/4591a210a8d924d99811edfdfeb7433452e5eeb4/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java#L184-L185
This is confusing. The internal executor was introduced in #8208 and that
change uses `numIOThreads` parameter also for configuring the number of threads
for the internal executor. @merlimat I wonder what would be a way to improve
this situation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
