lhotari commented on a change in pull request #13839:
URL: https://github.com/apache/pulsar/pull/13839#discussion_r788342535
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -245,6 +245,13 @@
)
private int numIOThreads = 2 * Runtime.getRuntime().availableProcessors();
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "Number of shared threads to use for broker clients."
+ + " Default is set to `2 *
Runtime.getRuntime().availableProcessors()`"
+ )
+ private int brokerClientNumIOThreads = 2 *
Runtime.getRuntime().availableProcessors();
Review comment:
> Additionally, the client internal executor shouldn't really be used a
lot in broker, since it's used mainly for dispatching the partitioned/multi
topic consumers, so we could just default to 1 thread instead.
yes, that is true. I wonder if the value needs to be configurable at all?
I'll remove brokerClientNumIOThreads key and just use the value 1 as I did for
the external executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
