dlg99 commented on a change in pull request #13716:
URL: https://github.com/apache/pulsar/pull/13716#discussion_r789058021
##########
File path: pulsar-io/flume/pom.xml
##########
@@ -106,7 +125,7 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
- <version>18.0</version>
+ <version>${guava.version}</version>
Review comment:
@lhotari the best testing I could do is:
1. get flume's code.
2. checkout d4fcab4f501d41597bc616921329a4339f73585e (last release), build.
Build fails, with jdk 11 and jdk 8.
3. checkout `trunk` (some dependencies upgraded after the release but no
dramatic changes). build succeeds.
4. the guava dependency is brought in by `org.apache.flume:flume-ng-node` -
so `cd flume/flume-ng-node` and run tests there. tests pass (with jdk8, some
failed with jdk11)
5. force `<version>31.0.1-jre</version>` for guava in `flume-ng-node`. Build
succeeds. `mvn dependency:tree` confirms that updated guava is used. The tests
pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
