nodece commented on a change in pull request #13786:
URL: https://github.com/apache/pulsar/pull/13786#discussion_r789320776
##########
File path:
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java
##########
@@ -67,9 +67,13 @@
)
private String globalZookeeperServers;
+ @Deprecated
@FieldContext(doc = "Connection string of configuration store servers")
private String configurationStoreServers;
+ @FieldContext(doc = "Connection string of configuration metadata store
servers")
+ private String configurationMetadataStoreUrl;
Review comment:
Looks like we should be compatible with the old config, overwrite the
`getConfigurationMetadataStoreUrl()`, so like:
```java
public String getConfigurationMetadataStoreUrl() {
if (StringUtils.isNotEmpty(this.configurationMetadataStoreUrl)) {
return this.configurationMetadataStoreUrl;
}
// backward compatible
if (StringUtils.isNotEmpty(this.configurationStoreServers)) {
return this.configurationStoreServers;
}
return this.globalZookeeperServers;
}
```
You also need to check the usage, use
`WebSocketProxyConfiguration#getConfigurationMetadataStoreUrl()` instead of
`globalZookeeperServers()` and `getConfigurationStoreServers()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
