RobertIndie commented on a change in pull request #13786:
URL: https://github.com/apache/pulsar/pull/13786#discussion_r789345842
##########
File path:
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java
##########
@@ -67,9 +67,13 @@
)
private String globalZookeeperServers;
+ @Deprecated
@FieldContext(doc = "Connection string of configuration store servers")
private String configurationStoreServers;
+ @FieldContext(doc = "Connection string of configuration metadata store
servers")
+ private String configurationMetadataStoreUrl;
Review comment:
This has already been done in
`ServiceConfiguration.getConfigurationMetadataStoreUrl`. When initializing the
`WebSocketService`, we will convert `WebSocketProxyConfiguration` to
`ServiceConfiguration` via `PulsarConfigurationLoader.convertFrom`. Backward
compatibility has been done in `ServiceConfiguration`.
> You also need to check the usage, use
`WebSocketProxyConfiguration#getConfigurationMetadataStoreUrl()` instead of
`globalZookeeperServers()` and `getConfigurationStoreServers()`.
I have already checked that. There is no direct use of
`getGlobalZookeeperServers` or `getConfigurationStoreServers ` of
`WebSocketProxyConfiguration ` and there shouldn't be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
