wolfstudy commented on a change in pull request #706:
URL: https://github.com/apache/pulsar-client-go/pull/706#discussion_r789362350
##########
File path: pulsar/consumer_partition.go
##########
@@ -596,7 +596,7 @@ func (pc *partitionConsumer) MessageReceived(response
*pb.CommandMessage, header
msgID := newTrackingMessageID(
int64(pbMsgID.GetLedgerId()),
int64(pbMsgID.GetEntryId()),
- int32(i),
+ pbMsgID.GetBatchIndex(),
Review comment:
Yes, this may break compatibility. The Java SDK side obtains the Batch
Idx information from the Broker instead of maintaining the index information
locally.
Therefore, if the user uses the Java SDK on the producer side and the Go SDK
on the consumer side, there is no way to match the attributes of the message ID.
This effect is relatively small and only affects non-partitioned topic
types. In most cases, users may prefer to use partitioned-topic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
