Jason918 commented on a change in pull request #13890:
URL: https://github.com/apache/pulsar/pull/13890#discussion_r789672260
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -3264,55 +3264,73 @@ protected MessageId internalTerminate(boolean
authoritative) {
}
protected void internalTerminatePartitionedTopic(AsyncResponse
asyncResponse, boolean authoritative) {
+ CompletableFuture<Void> future;
if (topicName.isGlobal()) {
- validateGlobalNamespaceOwnership(namespaceName);
- }
- validateTopicOwnership(topicName, authoritative);
- validateTopicOperation(topicName, TopicOperation.TERMINATE);
-
- Map<Integer, MessageId> messageIds = new ConcurrentHashMap<>();
-
- PartitionedTopicMetadata partitionMetadata =
getPartitionedTopicMetadata(topicName, authoritative, false);
-
- if (partitionMetadata.partitions == 0) {
- throw new RestException(Status.METHOD_NOT_ALLOWED, "Termination of
a non-partitioned topic is "
- + "not allowed using partitioned-terminate, please use
terminate commands.");
- }
- if (partitionMetadata.partitions > 0) {
- final List<CompletableFuture<MessageId>> futures =
Lists.newArrayList();
+ future = validateGlobalNamespaceOwnershipAsync(namespaceName);
+ } else {
+ future = CompletableFuture.completedFuture(null);
+ }
+
+ future.thenAccept(__ -> validateTopicOwnershipAsync(topicName,
authoritative)
+ .thenCompose(unused -> validateTopicOperationAsync(topicName,
TopicOperation.TERMINATE))
+ .thenCompose(unused ->
getPartitionedTopicMetadataAsync(topicName, authoritative, false))
+ .thenAccept(partitionMetadata -> {
+ if (partitionMetadata.partitions == 0) {
+ String msg = "Termination of a non-partitioned topic
is not allowed using partitioned-terminate"
+ + ", please use terminate commands";
+ log.error("[{}] [{}] {}", clientAppId(), topicName,
msg);
+ asyncResponse.resume(new
RestException(Status.METHOD_NOT_ALLOWED, msg));
+ }
+ if (partitionMetadata.partitions > 0) {
+ Map<Integer, MessageId> messageIds = new
ConcurrentHashMap<>(partitionMetadata.partitions);
+ final List<CompletableFuture<MessageId>> futures =
+
Lists.newArrayListWithCapacity(partitionMetadata.partitions);
- for (int i = 0; i < partitionMetadata.partitions; i++) {
- TopicName topicNamePartition = topicName.getPartition(i);
- try {
- int finalI = i;
- futures.add(pulsar().getAdminClient().topics()
-
.terminateTopicAsync(topicNamePartition.toString()).whenComplete((messageId,
throwable) -> {
- if (throwable != null) {
- log.error("[{}] Failed to terminate topic {}",
clientAppId(), topicNamePartition,
- throwable);
- asyncResponse.resume(new
RestException(throwable));
- }
- messageIds.put(finalI, messageId);
- }));
- } catch (Exception e) {
- log.error("[{}] Failed to terminate topic {}", clientAppId(),
topicNamePartition, e);
- throw new RestException(e);
- }
- }
- FutureUtil.waitForAll(futures).handle((result, exception) -> {
- if (exception != null) {
- Throwable t = exception.getCause();
- if (t instanceof NotFoundException) {
- asyncResponse.resume(new RestException(Status.NOT_FOUND,
"Topic not found"));
- } else {
- log.error("[{}] Failed to terminate topic {}",
clientAppId(), topicName, t);
- asyncResponse.resume(new RestException(t));
- }
- }
- asyncResponse.resume(messageIds);
+ for (int i = 0; i < partitionMetadata.partitions; i++)
{
+ TopicName topicNamePartition =
topicName.getPartition(i);
+ try {
+ int finalI = i;
+ futures.add(pulsar().getAdminClient().topics()
+
.terminateTopicAsync(topicNamePartition.toString())
+ .whenComplete((messageId, throwable)
-> {
+ if (throwable != null) {
+ log.error("[{}] Failed to
terminate topic {}", clientAppId(),
+ topicNamePartition,
throwable);
+ asyncResponse.resume(new
RestException(throwable));
+ }
+ messageIds.put(finalI, messageId);
+ }));
+ } catch (Exception e) {
+ log.error("[{}] Failed to terminate topic {}",
clientAppId(), topicNamePartition, e);
+ throw new RestException(e);
+ }
+ }
+ FutureUtil.waitForAll(futures).handle((result,
exception) -> {
+ if (exception != null) {
+ Throwable t = exception.getCause();
+ if (t instanceof NotFoundException) {
+ asyncResponse.resume(new
RestException(Status.NOT_FOUND, "Topic not found"));
+ } else {
+ log.error("[{}] Failed to terminate topic
{}", clientAppId(), topicName, t);
+ asyncResponse.resume(new RestException(t));
+ }
+ }
+ asyncResponse.resume(messageIds);
+ return null;
+ });
+ }
+ }).exceptionally(e -> {
+ Throwable cause = e.getCause();
Review comment:
Can this exception be handled by the `exceptionally` outside?
Seems like duplicate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
