michaeljmarshall opened a new pull request #13949: URL: https://github.com/apache/pulsar/pull/13949
### Motivation In https://github.com/apache/pulsar/pull/12874, we reply to the client in all cases. That is not our current design though. We should only send the error response to the client when the code is able to complete the `producerFuture`. This logic is described here: https://github.com/apache/pulsar/blob/2285d02aa9957af7877b9d3d3c628a750d813ca7/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L1286-L1293 ### Modifications * Move the response to the client into a conditional block that only runs when this section of the code is able to complete the future. ### Verifying this change This is a trivial change. ### Does this pull request potentially affect one of the following parts: It impacts how the broker interacts with the client. This change ensures that we have the correct behavior. ### Documentation - [x] `no-need-doc` This change is completely internal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
