michaeljmarshall commented on pull request #13949:
URL: https://github.com/apache/pulsar/pull/13949#issuecomment-1021842420


   > > In #12874, we reply to the client in all cases. That is not our current 
design though.
   > 
   > This issue exists long before #12874 which just changed the sync blocking 
to async implementation.
   > 
   > I wonder if there are some other cases have the same issue.
   
   @Jason918 - thank you for calling this out, sorry about that misattribution. 
I noticed the code today when looking at recent changes, but I failed to dig 
deep enough to know that it predated your commit. I updated the PR description.
   
   I did inspect the rest of the class today, and I don't see the behavior 
anywhere else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to