Technoboy- commented on a change in pull request #13777:
URL: https://github.com/apache/pulsar/pull/13777#discussion_r792336371
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
##########
@@ -72,13 +72,15 @@
@Parameter(names = { "-zk", "--zookeeper-servers" }, description = "Local
zookeeper connection string")
private String zookeeperServers = "";
+ @Parameter(names = { "-md", "--metadata-store" }, description = "Metadata
Store service url. eg: zk:my-zk:2181")
+ private String metadataStoreUrl = "";
@Deprecated
@Parameter(names = { "-gzk", "--global-zookeeper-servers" }, description =
"Global zookeeper connection string")
private String globalZookeeperServers = "";
@Parameter(names = { "-cs", "--configuration-store-servers" },
- description = "Configuration store connection string")
+ description = "Configuration store connection string")
private String configurationStoreServers = "";
Review comment:
Why not add `configurationMetadataStoreUrl` and add @Deprecated to this.
Also , add @Deprecated to `zookeeperServers`.
What do you think ? @gaozhangmin @codelipenghui @RobertIndie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
