Jason918 commented on a change in pull request #13777:
URL: https://github.com/apache/pulsar/pull/13777#discussion_r792336237
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
##########
@@ -72,13 +72,15 @@
@Parameter(names = { "-zk", "--zookeeper-servers" }, description = "Local
zookeeper connection string")
private String zookeeperServers = "";
Review comment:
This should be `Deprecated` and add "deprecation note" in description.
Or it would be confusing for command line user.
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
##########
@@ -131,30 +133,33 @@ public ProxyServiceStarter(String[] args) throws
Exception {
// load config file
config = PulsarConfigurationLoader.create(configFile,
ProxyConfiguration.class);
- if (!isBlank(zookeeperServers)) {
- // Use zookeeperServers from command line
- config.setZookeeperServers(zookeeperServers);
+ if (isBlank(metadataStoreUrl)) {
+ // Use zookeeperServers from command line if metadataStoreUrl
is empty;
+ config.setMetadataStoreUrl(zookeeperServers);
+ } else {
+ // Use metadataStoreUrl from command line
+ config.setMetadataStoreUrl(metadataStoreUrl);
}
if (!isBlank(globalZookeeperServers)) {
// Use globalZookeeperServers from command line
- config.setConfigurationStoreServers(globalZookeeperServers);
+
config.setConfigurationMetadataStoreUrl(globalZookeeperServers);
}
if (!isBlank(configurationStoreServers)) {
- // Use configurationStoreServers from command line
- config.setConfigurationStoreServers(configurationStoreServers);
+ // Use configurationMetadataStoreUrl from command line
+
config.setConfigurationMetadataStoreUrl(configurationStoreServers);
}
if ((isBlank(config.getBrokerServiceURL()) &&
isBlank(config.getBrokerServiceURLTLS()))
|| config.isAuthorizationEnabled()) {
- checkArgument(!isEmpty(config.getZookeeperServers()),
"zookeeperServers must be provided");
- checkArgument(!isEmpty(config.getConfigurationStoreServers()),
+ checkArgument(!isEmpty(config.getMetadataStoreUrl()),
"zookeeperServers must be provided");
Review comment:
There shouldn't be any "zookeeper" exposed to user anymore.
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
##########
@@ -72,13 +72,15 @@
@Parameter(names = { "-zk", "--zookeeper-servers" }, description = "Local
zookeeper connection string")
private String zookeeperServers = "";
+ @Parameter(names = { "-md", "--metadata-store" }, description = "Metadata
Store service url. eg: zk:my-zk:2181")
+ private String metadataStoreUrl = "";
@Deprecated
@Parameter(names = { "-gzk", "--global-zookeeper-servers" }, description =
"Global zookeeper connection string")
private String globalZookeeperServers = "";
@Parameter(names = { "-cs", "--configuration-store-servers" },
- description = "Configuration store connection string")
+ description = "Configuration store connection string")
private String configurationStoreServers = "";
Review comment:
> Do we need to add `configurationMetadataStore` and deprecate this
field to make it consistent with the config?
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
