nicoloboschi commented on a change in pull request #13777:
URL: https://github.com/apache/pulsar/pull/13777#discussion_r794252188
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
##########
@@ -131,30 +138,35 @@ public ProxyServiceStarter(String[] args) throws
Exception {
// load config file
config = PulsarConfigurationLoader.create(configFile,
ProxyConfiguration.class);
- if (!isBlank(zookeeperServers)) {
- // Use zookeeperServers from command line
- config.setZookeeperServers(zookeeperServers);
+ if (isBlank(metadataStoreUrl)) {
Review comment:
Well I don't see any retro compatibility test. You modified all the
tests to not use `zookeeperServers` anymore and that's ok. But I don't see a
test which verify what happens now with zookeeperServers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
