HQebupt commented on a change in pull request #14029:
URL: https://github.com/apache/pulsar/pull/14029#discussion_r795037085
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -3759,12 +3759,14 @@ protected void internalTriggerOffload(boolean
authoritative, MessageIdImpl messa
}
}
- protected OffloadProcessStatus internalOffloadStatus(boolean
authoritative) {
- validateTopicOwnership(topicName, authoritative);
- validateTopicOperation(topicName, TopicOperation.OFFLOAD);
-
- PersistentTopic topic = (PersistentTopic) getTopicReference(topicName);
- return topic.offloadStatus();
+ protected void internalOffloadStatus(AsyncResponse asyncResponse, boolean
authoritative) {
+ validateTopicOwnershipAsync(topicName, authoritative)
+ .thenCompose(__ -> validateTopicOperationAsync(topicName,
TopicOperation.OFFLOAD))
+ .thenCompose(__ -> getTopicReferenceAsync(topicName))
+ .thenAccept(topic -> {
+ OffloadProcessStatus offloadProcessStatus =
((PersistentTopic) topic).offloadStatus();
+ asyncResponse.resume(offloadProcessStatus);
+ });
Review comment:
Thanks, PTAL again. @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
