HQebupt commented on pull request #14029: URL: https://github.com/apache/pulsar/pull/14029#issuecomment-1025100639
> LGTM +1. but I have two suggestions: > > Remove asyncResponse from the internal method, and unified exception and result handling are performed at the controller layer, which makes the internal method purer. Have you checked to see if there is a test for the modified method ? @mattisonchao Thank you. I got your meaning. I will try your way in the following refactor. Truly, there are test failure due to the new modification in my other pull requests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
