merlimat commented on a change in pull request #1066: Issue 937: add
CommandGetLastMessageId to make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166481485
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java
##########
@@ -39,10 +39,11 @@
protected final long entryId;
protected final int partitionIndex;
- // Private constructor used only for json deserialization
- @SuppressWarnings("unused")
- private MessageIdImpl() {
- this(-1, -1, -1);
+ // create MessageIdImpl use value of MessageId.earliest
+ public MessageIdImpl() {
Review comment:
Since the `MessageidImpl` is immutable, couldn't we just reference
`MessageId.earliest` instead of constructing a new one equal to that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
