merlimat commented on a change in pull request #1066: Issue 937: add
CommandGetLastMessageId to make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167382822
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1248,6 +1254,77 @@ public void seek(MessageId messageId) throws
PulsarClientException {
return seekFuture;
}
+ public boolean hasMessageAvailable() throws PulsarClientException {
+ try {
+ return hasMessageAvailableAsync().get();
+ } catch (ExecutionException | InterruptedException e) {
+ throw new PulsarClientException(e);
+ }
+ }
+
+ public CompletableFuture<Boolean> hasMessageAvailableAsync() {
+ final CompletableFuture<Boolean> booleanFuture = new
CompletableFuture<>();
+
+ if (lastMessageIdInBroker.compareTo(lastDequeuedMessage) > 0 &&
+ ((MessageIdImpl)lastMessageIdInBroker).getEntryId() != -1) {
+ booleanFuture.complete(true);
+ } else {
+ getLastMessageIdAsync().thenAccept(messageId -> {
+ lastMessageIdInBroker = messageId;
+ if (lastMessageIdInBroker.compareTo(lastDequeuedMessage) > 0 &&
+ ((MessageIdImpl)lastMessageIdInBroker).getEntryId() != -1)
{
+ booleanFuture.complete(true);
+ } else {
+ booleanFuture.complete(false);
+ }
+ }).exceptionally(e -> {
+ log.error("[{}][{}] Failed getLastMessageId command", topic,
subscription);
+ booleanFuture.completeExceptionally(e.getCause());
+ return null;
+ });
+ }
+ return booleanFuture;
+ }
+
+ private CompletableFuture<MessageId> getLastMessageIdAsync() {
+ if (getState() == State.Closing || getState() == State.Closed) {
+ return FutureUtil
+ .failedFuture(new
PulsarClientException.AlreadyClosedException("Consumer was already closed"));
+ }
+
+ if (cnx().getRemoteEndpointProtocolVersion() <
ProtocolVersion.v11.getNumber()) {
Review comment:
If it's not connected `cnx()` will return null here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
