merlimat commented on a change in pull request #1358: Issue 1071: add
ratelimiter for subscription
URL: https://github.com/apache/incubator-pulsar/pull/1358#discussion_r178470721
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java
##########
@@ -70,6 +71,7 @@ public
PersistentDispatcherSingleActiveConsumer(ManagedCursor cursor, SubType su
this.cursor = cursor;
this.readBatchSize = MaxReadBatchSize;
this.serviceConfig =
topic.getBrokerService().pulsar().getConfiguration();
+ this.dispatchRateLimiter = new DispatchRateLimiter(topic, name);
Review comment:
To avoid additional object per-consumer, when the rate limiter
per-subscription is disabled, would it be easy to initialize to null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
