merlimat commented on a change in pull request #1358: Issue 1071: add
ratelimiter for subscription
URL: https://github.com/apache/incubator-pulsar/pull/1358#discussion_r178470730
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
##########
@@ -172,6 +172,8 @@ public void deactivateCursor() {
@Override
public void consumerFlow(Consumer consumer, int
additionalNumberOfMessages) {
+ // TODO: add RateLimiter here?
Review comment:
No need to rate limit flow commands. Remove comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
