merlimat commented on a change in pull request #1365: Delete
PartitionedConsumerImpl, use TopicsConsumerImpl instead
URL: https://github.com/apache/incubator-pulsar/pull/1365#discussion_r174362714
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/PerMessageUnAcknowledgedRedeliveryTest.java
##########
@@ -338,7 +338,7 @@ public void testFailoverAckedNormalTopic() throws
Exception {
}
private static long
getUnackedMessagesCountInPartitionedConsumer(Consumer<byte[]> c) {
- PartitionedConsumerImpl<byte[]> pc = (PartitionedConsumerImpl<byte[]>)
c;
+ TopicsConsumerImpl<byte[]> pc = (TopicsConsumerImpl<byte[]>) c;
Review comment:
I think we could also rename `TopicsConsumerImpl` into
`MultiTopicsConsumerImpl`, because `TopicsConsumerImpl` doesn't immediately
convey that it's working on a collection of topics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
