rdhabalia commented on a change in pull request #1707: Fixed authentication
flow via Pulsar Proxy
URL: https://github.com/apache/incubator-pulsar/pull/1707#discussion_r185666469
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
##########
@@ -229,14 +245,39 @@ protected void handleLookup(CommandLookupTopic lookup) {
private void close() {
state = State.Closed;
ctx.close();
+ try {
+ client.close();
+ } catch (PulsarClientException e) {
+ LOG.error("Unable to clode pulsar client - {}", client);
Review comment:
type `close ` and add `e.getMessage()` in log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
