rdhabalia commented on a change in pull request #1707: Fixed authentication
flow via Pulsar Proxy
URL: https://github.com/apache/incubator-pulsar/pull/1707#discussion_r185667124
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
##########
@@ -259,13 +295,34 @@ private boolean
verifyAuthenticationIfNeeded(CommandConnect connect) {
clientAuthRole =
service.getAuthenticationService().authenticate(authenticationData, authMethod);
LOG.info("[{}] Client successfully authenticated with {} role {}",
remoteAddress, authMethod,
clientAuthRole);
+ if (service.getConfiguration().forwardAuthorizationCredentials()) {
+ this.clientAuthData = authData;
+ this.clientAuthMethod = authMethod;
+ }
+ createClient(clientConf, this.clientAuthData,
this.clientAuthMethod);
Review comment:
as name suggests. can we create and return client in `createClient()`:
`this.client = createClient(..)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
