[GitHub] merlimat closed pull request #1771: setting auto ack to be true for sources and sinks

[GitBox]

merlimat closed pull request #1771: setting auto ack to be true for sources and 
sinks
URL: https://github.com/apache/incubator-pulsar/pull/1771
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
index bac98d9331..b9a497a07f 100644
--- 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
+++ 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
@@ -294,6 +294,7 @@ protected FunctionDetails createSinkConfig(SinkConfig 
sinkConfig) {
             
sourceSpecBuilder.setSubscriptionType(Function.SubscriptionType.SHARED);
             
sourceSpecBuilder.putAllTopicsToSerDeClassName(sinkConfig.getTopicToSerdeClassName());
             sourceSpecBuilder.setTypeClassName(typeArg.getName());
+            functionDetailsBuilder.setAutoAck(true);
             functionDetailsBuilder.setSource(sourceSpecBuilder);
 
             // set up sink spec
diff --git 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
index 267673c9b7..cc4bc650a7 100644
--- 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
+++ 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
@@ -267,6 +267,7 @@ protected FunctionDetails createSourceConfig(SourceConfig 
sourceConfig) {
             functionDetailsBuilder.setRuntime(FunctionDetails.Runtime.JAVA);
             
functionDetailsBuilder.setParallelism(sourceConfig.getParallelism());
             
functionDetailsBuilder.setClassName(IdentityFunction.class.getName());
+            functionDetailsBuilder.setAutoAck(true);
             if (sourceConfig.getProcessingGuarantees() != null) {
                 functionDetailsBuilder.setProcessingGuarantees(
                         
convertProcessingGuarantee(sourceConfig.getProcessingGuarantees()));


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services