This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 75643da  setting auto ack to be true for sources and sinks (#1771)
75643da is described below

commit 75643daea9a9ea527fb61dc6f186e9d01c2bb7bc
Author: Boyang Jerry Peng <[email protected]>
AuthorDate: Mon May 14 15:49:28 2018 -0700

    setting auto ack to be true for sources and sinks (#1771)
---
 .../src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java              | 1 +
 .../src/main/java/org/apache/pulsar/admin/cli/CmdSources.java            | 1 +
 2 files changed, 2 insertions(+)

diff --git 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
index fb0bd65..04e73bf 100644
--- 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
+++ 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
@@ -293,6 +293,7 @@ public class CmdSinks extends CmdBase {
             
sourceSpecBuilder.setSubscriptionType(Function.SubscriptionType.SHARED);
             
sourceSpecBuilder.putAllTopicsToSerDeClassName(sinkConfig.getTopicToSerdeClassName());
             sourceSpecBuilder.setTypeClassName(typeArg.getName());
+            functionDetailsBuilder.setAutoAck(true);
             functionDetailsBuilder.setSource(sourceSpecBuilder);
 
             // set up sink spec
diff --git 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
index b78ebde..1583589 100644
--- 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
+++ 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
@@ -267,6 +267,7 @@ public class CmdSources extends CmdBase {
             functionDetailsBuilder.setRuntime(FunctionDetails.Runtime.JAVA);
             
functionDetailsBuilder.setParallelism(sourceConfig.getParallelism());
             
functionDetailsBuilder.setClassName(IdentityFunction.class.getName());
+            functionDetailsBuilder.setAutoAck(true);
             if (sourceConfig.getProcessingGuarantees() != null) {
                 functionDetailsBuilder.setProcessingGuarantees(
                         
convertProcessingGuarantee(sourceConfig.getProcessingGuarantees()));

-- 
To stop receiving notification emails like this one, please contact
[email protected].

Reply via email to