ivankelly commented on a change in pull request #1858: Cpp client: add
readCompacted in consumer config
URL: https://github.com/apache/incubator-pulsar/pull/1858#discussion_r191685639
##########
File path: pulsar-client-cpp/lib/ClientImpl.cc
##########
@@ -222,6 +222,12 @@ void ClientImpl::subscribeAsync(const std::string& topic,
const std::string& con
lock.unlock();
callback(ResultInvalidTopicName, Consumer());
return;
+ } else if (conf.isReadCompacted() &&
(topicName->getDomain().compare("persistent") != 0 ||
Review comment:
Is "persistent" defined as a const anywhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
