ivankelly commented on a change in pull request #1858: Cpp client: add
readCompacted in consumer config
URL: https://github.com/apache/incubator-pulsar/pull/1858#discussion_r191685411
##########
File path: pulsar-client-cpp/include/pulsar/ReaderConfiguration.h
##########
@@ -86,6 +86,9 @@ class ReaderConfiguration {
void setSubscriptionRolePrefix(const std::string& subscriptionRolePrefix);
const std::string& getSubscriptionRolePrefix() const;
+ void setReadCompacted(bool compacted);
Review comment:
Why isn't this returning ReaderConfiguration&? I see some others are not
returning it, but I would guess it's to not break BC. setReaderListener does
return it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
